nsivabalan commented on code in PR #17935:
URL: https://github.com/apache/hudi/pull/17935#discussion_r2734029409
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java:
##########
@@ -1016,6 +1027,11 @@ public Builder withLogCompactBlocksThreshold(int
logCompactBlocksThreshold) {
return this;
}
+ public HoodieMetadataConfig.Builder withMainTableCleanPolicy(boolean
useMainTableCleanPolicy) {
Review Comment:
same here
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java:
##########
@@ -151,6 +151,13 @@ public final class HoodieMetadataConfig extends
HoodieConfig {
.sinceVersion("0.14.0")
.withDocumentation("Controls the criteria to log compacted files groups
in metadata table.");
+ public static final ConfigProperty<Boolean> USE_MAIN_TABLE_CLEAN_POLICY =
ConfigProperty
+ .key(METADATA_PREFIX + ".use.main.table.clean.policy")
Review Comment:
`METADATA_PREFIX + derive.datatable.clean.policy`
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataWriteUtils.java:
##########
@@ -159,24 +159,30 @@ public static HoodieWriteConfig createMetadataWriteConfig(
final long maxLogFileSizeBytes =
writeConfig.getMetadataConfig().getMaxLogFileSize();
// Borrow the cleaner policy from the main table and adjust the cleaner
policy based on the main table's cleaner policy
+ boolean useMainTableCleanPolicy =
writeConfig.getMetadataConfig().useMainTableCleanPolicy();
Review Comment:
`driveFromDatatableCleanPolicy`
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java:
##########
@@ -151,6 +151,13 @@ public final class HoodieMetadataConfig extends
HoodieConfig {
.sinceVersion("0.14.0")
.withDocumentation("Controls the criteria to log compacted files groups
in metadata table.");
+ public static final ConfigProperty<Boolean> USE_MAIN_TABLE_CLEAN_POLICY =
ConfigProperty
+ .key(METADATA_PREFIX + ".use.main.table.clean.policy")
+ .defaultValue(true)
+ .markAdvanced()
+ .sinceVersion("1.2.0")
+ .withDocumentation("This config determines whether the cleaner policy
should use main table's cleaner policy.");
Review Comment:
fix the wording. main -> data
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java:
##########
@@ -887,6 +894,10 @@ public int getRecordPreparationParallelism() {
return getIntOrDefault(RECORD_PREPARATION_PARALLELISM);
}
+ public boolean useMainTableCleanPolicy() {
Review Comment:
fix the naming once the config key and property is fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
