rahil-c opened a new pull request, #18042:
URL: https://github.com/apache/hudi/pull/18042

   
   ### Describe the issue this Pull Request addresses
   
   Recently encountered the following exceptions captured in this 
[gist](https://gist.github.com/rahil-c/fd53e2d5f1033743c8f6ae9ebb5baddc) when 
trying to hook up lance with the FGReader related tests in order to test schema 
evolution. 
   
   1. Currently in `TestLanceDataSource` we do not have a case where the user 
specifies a recordKey field and also is setting the populateMetaFields to 
false, without this change users will hit the NPE mentioned in the gist. For 
now I have added a simpler test in TestLanceDataSource, to block on the ongoing 
efforts with getting FGReader test suite to work with Lance in this pr here: 
https://github.com/apache/hudi/pull/17904
   
   2. The second exception was a more general exception around the fact that we 
have not wired in Lance in the `MultipleColumnarFileFormatReader`
   
   ### Summary and Changelog
   
   * Fixes for both issues mentioned above
   * Adds a test in TestLanceDataSource for the case of user defined key and 
populateMetaFields false
   
   ### Impact
   
   none
   
   ### Risk Level
   
   low
   
   ### Documentation Update
   
   none
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Enough context is provided in the sections above
   - [ ] Adequate tests were added if applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to