rahil-c commented on code in PR #18042:
URL: https://github.com/apache/hudi/pull/18042#discussion_r2743119230
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/common/SparkReaderContextFactory.java:
##########
@@ -153,6 +154,17 @@ private static SparkColumnarFileReader
getOrcFileReader(TableSchemaResolver reso
}
}
+ private static SparkColumnarFileReader getLanceFileReader(SQLConf sqlConf,
Review Comment:
I am ok with inling, its just that for the ORC reader you created a
[function](https://github.com/apache/hudi/blob/eafe069c8da9726a8437251805f746fe38ea697b/hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/common/SparkReaderContextFactory.java#L143)
so was following similar pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
