rahil-c commented on code in PR #17904:
URL: https://github.com/apache/hudi/pull/17904#discussion_r2744426381
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/HoodieParquetFileFormatHelper.scala:
##########
@@ -174,24 +175,55 @@ object HoodieParquetFileFormatHelper {
}
}
- if (typeChangeInfos.isEmpty) {
- GenerateUnsafeProjection.generate(fullSchema, fullSchema)
+ def generateProjectionWithPadding(): UnsafeProjection = {
Review Comment:
@the-other-tim-brown so to clarify you are saying you want to move the logic
of `generateProjectionWithPadding` into the `SparkLanceReaderBase`? Was
originally focused on getting things functionally working so let me know how
how you would like me to refactor this otherwise was planning on just keeping
things as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
