rahil-c commented on code in PR #17904:
URL: https://github.com/apache/hudi/pull/17904#discussion_r2748679238
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/HoodieParquetFileFormatHelper.scala:
##########
@@ -174,24 +175,55 @@ object HoodieParquetFileFormatHelper {
}
}
- if (typeChangeInfos.isEmpty) {
- GenerateUnsafeProjection.generate(fullSchema, fullSchema)
+ def generateProjectionWithPadding(): UnsafeProjection = {
Review Comment:
I have done a refactoring of moving several shared utils that both parquet
and lance call to another class called `SparkSchemaTransformUtils` in order to
try to reuse the existing code but organize it in an area that maybe is less
confusing then the last commit. If you think this refactoring is not the ideal
direction, would need more specifics on how you are picturing the refactor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
