PavithranRick commented on code in PR #18073:
URL: https://github.com/apache/hudi/pull/18073#discussion_r2760967366
##########
hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/handlers/marker/MarkerDirState.java:
##########
@@ -301,9 +325,10 @@ private void syncMarkersFromFileSystem() {
*
* @param fileIndex Marker file index number.
* @param markerName Marker name.
+ * @param requestId Optional request ID for idempotency; null for legacy or
recovery.
*/
- private void addMarkerToMap(int fileIndex, String markerName) {
- allMarkers.add(markerName);
+ private void addMarkerToMap(int fileIndex, String markerName, String
requestId) {
+ markerToRequestIdMap.put(markerName, requestId == null ? NULL_REQUEST_ID :
requestId);
Review Comment:
But we'd need it to fail requests after TLS crash recovery
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
