PavithranRick commented on code in PR #18073:
URL: https://github.com/apache/hudi/pull/18073#discussion_r2761220189
##########
hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/handlers/MarkerHandler.java:
##########
@@ -237,18 +240,18 @@ public CompletableFuture<String> createMarker(Context
context, String markerDir,
log.warn("Failed to execute early conflict detection. Marker creation
will continue.", e);
// When early conflict detection fails to execute, we still allow the
marker creation
// to continue
- return addMarkerCreationRequestForAsyncProcessing(context, markerDir,
markerName);
+ return addMarkerCreationRequestForAsyncProcessing(context, markerDir,
markerName, requestId);
}
}
// Step 2 create marker
- return addMarkerCreationRequestForAsyncProcessing(context, markerDir,
markerName);
+ return addMarkerCreationRequestForAsyncProcessing(context, markerDir,
markerName, requestId);
}
private MarkerCreationFuture addMarkerCreationRequestForAsyncProcessing(
- Context context, String markerDir, String markerName) {
+ Context context, String markerDir, String markerName, String requestId) {
log.debug("Request: Create marker: {}", markerName);
- MarkerCreationFuture future = new MarkerCreationFuture(context, markerDir,
markerName);
+ MarkerCreationFuture future = new MarkerCreationFuture(context, markerDir,
markerName, requestId);
Review Comment:
Thank you. Nice catch. Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
