xushiyan commented on code in PR #18082:
URL: https://github.com/apache/hudi/pull/18082#discussion_r2766500754
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/HoodieSource.java:
##########
@@ -126,16 +130,26 @@ private SplitEnumerator<HoodieSourceSplit,
HoodieSplitEnumeratorState> createEnu
SplitEnumeratorContext<HoodieSourceSplit> enumContext,
@Nullable HoodieSplitEnumeratorState enumeratorState) {
HoodieSplitProvider splitProvider;
+ HoodieSplitAssigner splitAssigner;
+
+ if (OptionsResolver.isMorWithBucketIndexUpsert(scanContext.getConf())) {
+ splitAssigner = new
HoodieSplitBucketAssigner(enumContext.currentParallelism());
+ } else {
+ splitAssigner = new
DefaultHoodieSplitAssigner(enumContext.currentParallelism());
+ }
+
if (enumeratorState == null) {
- splitProvider = new DefaultHoodieSplitProvider(new
HoodieSourceSplitComparator());
+ splitProvider = new DefaultHoodieSplitProvider(
+ new HoodieSourceSplitComparator(),
+ splitAssigner);
} else {
LOG.info(
"Hoodie source restored {} splits from state for table {}",
enumeratorState.getPendingSplitStates().size(),
metaClient.getTableConfig().getTableName());
List<HoodieSourceSplit> pendingSplits =
enumeratorState.getPendingSplitStates().stream().map(HoodieSourceSplitState::split).collect(Collectors.toList());
- splitProvider = new DefaultHoodieSplitProvider();
+ splitProvider = new DefaultHoodieSplitProvider(splitAssigner);
Review Comment:
when restore from state, comparator is not passed to this constructor, this
can lead to inconsistent ordering of splits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
