xushiyan commented on code in PR #18082:
URL: https://github.com/apache/hudi/pull/18082#discussion_r2766557001
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/split/DefaultHoodieSplitProvider.java:
##########
Review Comment:
this api should return the same future, not creating new future every time,
like using
```java
private final AtomicReference<CompletableFuture<Void>> availableFuture =
new AtomicReference<>(new CompletableFuture<>());
```
then `onDiscoveredSplits()` and `onUnassignedSplits()` should complete it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
