the-other-tim-brown commented on code in PR #17904:
URL: https://github.com/apache/hudi/pull/17904#discussion_r2771868711
##########
hudi-common/src/test/java/org/apache/hudi/common/table/read/TestHoodieFileGroupReaderBase.java:
##########
@@ -128,12 +130,196 @@ public abstract class TestHoodieFileGroupReaderBase<T> {
public abstract String getCustomPayload();
- public abstract void commitToTable(List<HoodieRecord> recordList,
+ public abstract void commitProcessedRecordsToTable(List<HoodieRecord>
recordList,
String operation,
boolean firstCommit,
Map<String, String> writeConfigs,
String schemaStr);
+ public void commitToTable(List<HoodieRecord> recordList,
+ String operation,
+ boolean firstCommit,
+ Map<String, String> writeConfigs,
+ String schemaStr) {
+ boolean isLance =
writeConfigs.getOrDefault(HoodieTableConfig.BASE_FILE_FORMAT.key(),
HoodieFileFormat.PARQUET.name()).equalsIgnoreCase(HoodieFileFormat.LANCE.name());
+ if (isLance) {
Review Comment:
Let's add context here for the special handling required by Lance for future
developers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
