rahil-c commented on code in PR #17904:
URL: https://github.com/apache/hudi/pull/17904#discussion_r2774975413
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestLanceDataSource.scala:
##########
@@ -745,4 +746,180 @@ class TestLanceDataSource extends
HoodieSparkClientTestBase {
writer.mode(saveMode).save(tablePath)
}
+
+ @ParameterizedTest
Review Comment:
In terms of coverage you are right that the fg reader tests offer the same
coverage at a much more detailed level with more complex schemas. These tests
were added since they were much faster to run and allowed for easier debugging
since they operated on smaller schemas.
If we want to avoid ci taking longer then I can remove them(and just have
them kept in a local text file for my own debugging when required).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
