voonhous commented on code in PR #18120:
URL: https://github.com/apache/hudi/pull/18120#discussion_r2777480803
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/helpers/TestProtoConversionUtil.java:
##########
@@ -301,7 +301,7 @@ private Pair<Sample, GenericRecord>
createInputOutputSampleWithRandomValues(Sche
wrappedStringOutput = getWrappedRecord(schema, "wrapped_string",
wrappedString);
wrappedIntOutput = getWrappedRecord(schema, "wrapped_int", wrappedInt);
wrappedLongOutput = getWrappedRecord(schema, "wrapped_long",
wrappedLong);
- wrappedUIntOutput = getWrappedRecord(schema, "wrapped_unsigned_int",
(long) wrappedUnsignedInt);
+ wrappedUIntOutput = getWrappedRecord(schema, "wrapped_unsigned_int",
Integer.toUnsignedLong(wrappedUnsignedInt));
Review Comment:
Sorry, i am away from a physical workstation for the next 7 days, but can
you plesae check, is this test failure introduced by my Lombok refactoring here?
https://github.com/apache/hudi/pull/17876/changes#diff-c28325986ee6b8550d5a840a880ec900c842d96fc733f9e58c9655088a2bd7adR447
I was fairly certain when reviewing the codepath that this path will only
handle unsigned integers, which is why i changed it to a unsigned integer to
unsigned long conversion.
From the code changes here, it seems that it's a matter of tests written
wrongly instead of incorrect refactoring right?
Just wanted to be doubly sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
