suryaprasanna commented on code in PR #18120:
URL: https://github.com/apache/hudi/pull/18120#discussion_r2778582579
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/helpers/TestProtoConversionUtil.java:
##########
@@ -301,7 +301,7 @@ private Pair<Sample, GenericRecord>
createInputOutputSampleWithRandomValues(Sche
wrappedStringOutput = getWrappedRecord(schema, "wrapped_string",
wrappedString);
wrappedIntOutput = getWrappedRecord(schema, "wrapped_int", wrappedInt);
wrappedLongOutput = getWrappedRecord(schema, "wrapped_long",
wrappedLong);
- wrappedUIntOutput = getWrappedRecord(schema, "wrapped_unsigned_int",
(long) wrappedUnsignedInt);
+ wrappedUIntOutput = getWrappedRecord(schema, "wrapped_unsigned_int",
Integer.toUnsignedLong(wrappedUnsignedInt));
Review Comment:
@voonhous No worries, thank you for raising the question.
I think your refactoring actually fixed a latent bug in the production code,
the test was also wrongly written as well. So, fixing the test would solve the
issue.
Will there be data correction for all users who were using the previous code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
