yihua commented on code in PR #18130:
URL: https://github.com/apache/hudi/pull/18130#discussion_r2780666566
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/HoodieSource.java:
##########
@@ -127,7 +128,9 @@ public
SimpleVersionedSerializer<HoodieSplitEnumeratorState> getEnumeratorCheckp
@Override
public SourceReader<T, HoodieSourceSplit> createReader(SourceReaderContext
readerContext) throws Exception {
- return new HoodieSourceReader<T>(recordEmitter, scanContext.getConf(),
readerContext, readerFunction, splitComparator);
+ FlinkStreamReadMetrics readMetrics = new
FlinkStreamReadMetrics(readerContext.metricGroup());
+ readMetrics.registerMetrics();
Review Comment:
The delay metrics are computed on-the-fly in the gauge lambdas. When
`setIssuedInstant()` or `setSplitLatestCommit()` update the instant values, the
delay gauges automatically calculate `currentTime - instant` each time they're
read. So the delays are derived metrics rather than explicitly set values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
