cshuo commented on code in PR #18130:
URL: https://github.com/apache/hudi/pull/18130#discussion_r2780783871


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/HoodieSource.java:
##########
@@ -127,7 +128,9 @@ public 
SimpleVersionedSerializer<HoodieSplitEnumeratorState> getEnumeratorCheckp
 
   @Override
   public SourceReader<T, HoodieSourceSplit> createReader(SourceReaderContext 
readerContext) throws Exception {
-    return new HoodieSourceReader<T>(recordEmitter, scanContext.getConf(), 
readerContext, readerFunction, splitComparator);
+    FlinkStreamReadMetrics readMetrics = new 
FlinkStreamReadMetrics(readerContext.metricGroup());
+    readMetrics.registerMetrics();

Review Comment:
   `setIssuedInstant()` covers `issuedInstantDelay` and `issuedInstant`; 
`setSplitLatestCommit` covers `setSplitLatestCommit` and 
`splitLatestCommitDelay`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to