prashantwason commented on PR #18058: URL: https://github.com/apache/hudi/pull/18058#issuecomment-3888181568
Addressed review comments: 1. **Use `createImmutableFileInPath`**: Refactored to use `HoodieStorage.createImmutableFileInPath()` for atomic file writes instead of manual temp file + rename approach. This handles temp file creation/cleanup internally. 2. **Renamed "Precombine" to "Ordering field"**: Updated error message to use "Ordering field" instead of "Precombine/ordering field" since precombine notion is deprecated since 1.1. @hudi-bot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
