danny0405 commented on code in PR #18058:
URL: https://github.com/apache/hudi/pull/18058#discussion_r2796880358
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java:
##########
@@ -540,27 +541,31 @@ private static void modify(HoodieStorage storage,
StoragePath metadataFolder, Pr
// 3. delete the properties file, reads will go to the backup, until we
are done.
deleteFile(storage, cfgPath);
- // 4. Upsert and save back.
- String checksum;
- try (OutputStream out = storage.create(cfgPath, true)) {
- propsToUpdate.accept(props, modifyProps);
- propsToDelete.forEach(propToDelete -> props.remove(propToDelete));
- checksum = storeProperties(props, out, cfgPath);
- }
+ // 4. Upsert and save back using createImmutableFileInPath for atomic
writes
+ propsToUpdate.accept(props, modifyProps);
Review Comment:
do you think the fix is necessary after these two fixes:
- https://github.com/apache/hudi/pull/13740
- https://github.com/apache/hudi/pull/14148
The integrity of both the backup file and cfg file could be ensured by the
checksum validation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
