nsivabalan commented on PR #18012: URL: https://github.com/apache/hudi/pull/18012#issuecomment-3899138034
I feel, we should keep it simple. start at the beginning of `compact()` method in TableServiceClient (irrespective of whether `shouldComplete` is true or not). w/n `completeCompaction`, in the end, we end the heart beat. but lets ensure we have a try catch block w/n compact(), so that w/n catch block we can stop the heart beat on failures. same applies to `completeCompaction` as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
