kbuci commented on PR #18012: URL: https://github.com/apache/hudi/pull/18012#issuecomment-3899792716
> I feel, we should keep it simple. > > start at the beginning of `compact()` method in TableServiceClient (irrespective of whether `shouldComplete` is true or not). > > w/n `completeCompaction`, in the end, we end the heart beat. That's what I originally tried. But the issue I saw though is that there could be case like https://github.com/apache/hudi/pull/18012#issuecomment-3846043607 where a user calls compact without comimting, and then calls compact again. So in that scenario we would need to stop the heartbeat of that first compact call be exiting, even though auto commit wasn't enabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
