yanghua commented on a change in pull request #2449:
URL: https://github.com/apache/hudi/pull/2449#discussion_r559404094



##########
File path: 
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java
##########
@@ -227,6 +227,9 @@ public static void main(String[] args) {
     }
     FileSystem fs = FSUtils.getFs(cfg.basePath, new Configuration());
     HiveConf hiveConf = new HiveConf();
+    if (cfg.hiveMetaStoreUri != null) {
+      hiveConf.set("hive.metastore.uris",cfg.hiveMetaStoreUri);

Review comment:
       If you want to remain this config option, it would be better to add more 
logic about its usage. That means it would be better to merge that PR into this 
one.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to