danny0405 commented on a change in pull request #2449:
URL: https://github.com/apache/hudi/pull/2449#discussion_r561628258
##########
File path:
hudi-spark-datasource/hudi-spark-common/src/main/java/org/apache/hudi/DataSourceUtils.java
##########
@@ -284,6 +284,9 @@ public static HiveSyncConfig
buildHiveSyncConfig(TypedProperties props, String b
props.getString(DataSourceWriteOptions.HIVE_PASS_OPT_KEY(),
DataSourceWriteOptions.DEFAULT_HIVE_PASS_OPT_VAL());
hiveSyncConfig.jdbcUrl =
props.getString(DataSourceWriteOptions.HIVE_URL_OPT_KEY(),
DataSourceWriteOptions.DEFAULT_HIVE_URL_OPT_VAL());
+ if (hiveSyncConfig.hiveMetaStoreUri != null) {
+ hiveSyncConfig.hiveMetaStoreUri =
props.getString(DataSourceWriteOptions.HIVE_URL_OPT_KEY(),
DataSourceWriteOptions.DEFAULT_HIVE_METASTORE_URI_OPT_VAL());
+ }
Review comment:
Looks weird, in which case the `hiveSyncConfig.hiveMetaStoreUri` can be
null and what is the priority between the `hiveSyncConfig` and the `props` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
