nsivabalan commented on code in PR #18305:
URL: https://github.com/apache/hudi/pull/18305#discussion_r2927723694
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java:
##########
@@ -949,13 +976,13 @@ protected void archive(HoodieTable table) {
}
/**
- * Get inflight timeline excluding compaction and clustering.
+ * Get inflight timeline excluding compaction, log compaction, and
clustering.
*
* @param metaClient
* @return
*/
private HoodieTimeline
getInflightTimelineExcludeCompactionAndClustering(HoodieTableMetaClient
metaClient) {
- HoodieTimeline inflightTimelineExcludingCompaction =
metaClient.getCommitsTimeline().filterPendingExcludingCompaction();
+ HoodieTimeline inflightTimelineExcludingCompaction =
metaClient.getCommitsTimeline().filterPendingExcludingCompactionAndLogCompaction();
Review Comment:
can you remind me, who is responsible for rolling back a failed
logCompaction?
Is it the log compaction thread or the ingestion thread also could rollback
a failed log compaction instant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
