kbuci commented on code in PR #18305:
URL: https://github.com/apache/hudi/pull/18305#discussion_r2927977856
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java:
##########
@@ -949,13 +976,13 @@ protected void archive(HoodieTable table) {
}
/**
- * Get inflight timeline excluding compaction and clustering.
+ * Get inflight timeline excluding compaction, log compaction, and
clustering.
*
* @param metaClient
* @return
*/
private HoodieTimeline
getInflightTimelineExcludeCompactionAndClustering(HoodieTableMetaClient
metaClient) {
- HoodieTimeline inflightTimelineExcludingCompaction =
metaClient.getCommitsTimeline().filterPendingExcludingCompaction();
+ HoodieTimeline inflightTimelineExcludingCompaction =
metaClient.getCommitsTimeline().filterPendingExcludingCompactionAndLogCompaction();
Review Comment:
In our org, because we only enable this on MDT, we only rollback the
logcompact either from
- the `performTableServices` API in MDT writer flow (which is triggered
during ingestion)
- Our table service platform
But I wasn't sure wether it was intended that rollbackFailedWrites also
rollback logcompactions. Since although currently the code in OSS technically
does this (since we aren't filtering out pending logcompaction plans here), I
wasn't sure if that was intentional or a bug/oversight
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
