bvaradar commented on code in PR #18065: URL: https://github.com/apache/hudi/pull/18065#discussion_r2928172185
########## hudi-hadoop-common/src/main/java/org/apache/hudi/avro/VariantShreddingProvider.java: ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.avro; + +import org.apache.hudi.common.schema.HoodieSchema; + +import org.apache.avro.Schema; +import org.apache.avro.generic.GenericRecord; + +/** + * Interface for shredding variant values at write time. + * <p> + * Implementations parse variant binary data (value + metadata bytes) and produce + * a shredded {@link GenericRecord} with typed_value columns populated according + * to the shredding schema. + * <p> + * This interface allows the variant binary parsing logic (which may depend on + * engine-specific libraries like Spark's variant module) to be loaded via reflection, + * keeping the core write support free of engine-specific dependencies. + */ +public interface VariantShreddingProvider { Review Comment: why is this class in hudi-hadoop-common and not in hudi-common ? ########## hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/storage/row/HoodieRowParquetWriteSupport.java: ########## @@ -129,6 +142,16 @@ public HoodieRowParquetWriteSupport(Configuration conf, StructType structType, O hadoopConf.set("spark.sql.parquet.writeLegacyFormat", writeLegacyFormatEnabled); hadoopConf.set("spark.sql.parquet.outputTimestampType", config.getStringOrDefault(HoodieStorageConfig.PARQUET_OUTPUT_TIMESTAMP_TYPE)); hadoopConf.set("spark.sql.parquet.fieldId.write.enabled", config.getStringOrDefault(PARQUET_FIELD_ID_WRITE_ENABLED)); + + // Variant shredding configs + this.variantWriteShreddingEnabled = config.getBooleanOrDefault(PARQUET_VARIANT_WRITE_SHREDDING_ENABLED); + this.variantForceShreddingSchemaForTest = config.getString(PARQUET_VARIANT_FORCE_SHREDDING_SCHEMA_FOR_TEST); Review Comment: Why does PARQUET_VARIANT_FORCE_SHREDDING_SCHEMA_FOR_TEST and other configs for tesing appear here ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
