nbalajee commented on code in PR #18279:
URL: https://github.com/apache/hudi/pull/18279#discussion_r2941325499
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/RollbackHelper.java:
##########
@@ -146,14 +151,25 @@ List<Pair<String, HoodieRollbackStat>>
maybeDeleteAndCollectStats(HoodieEngineCo
)
.withStorage(metaClient.getStorage())
.withTableVersion(tableVersion)
- .withFileExtension(HoodieLogFile.DELTA_EXTENSION).build();
+ .withFileExtension(HoodieLogFile.DELTA_EXTENSION);
+
Review Comment:
Your intuition is correct. In RollbackHelper, for V8+ the
getLogBlocksToBeDeleted() is always empty (and lines 136 through 205 is dead
code), because (a) For marker based rollbacks, log files use IoType.CREATE
(rollback blocks are not appended to existing log files, only new log files are
created). (b) For listing based rollback strategy,
"isTableVersionLessThanEight" guards against the append path.
Changes are applicable only to RollbackHelperV1.
Let me look into the fix and get back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
