nbalajee commented on code in PR #18279:
URL: https://github.com/apache/hudi/pull/18279#discussion_r2962388367
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/RollbackHelperV1.java:
##########
@@ -216,14 +219,25 @@ List<Pair<String, HoodieRollbackStat>>
maybeDeleteAndCollectStats(HoodieEngineCo
.withStorage(metaClient.getStorage())
.withFileCreationCallback(getRollbackLogMarkerCallback(writeMarkers,
partitionPath, fileId))
.withTableVersion(tableVersion)
- .withFileExtension(HoodieLogFile.DELTA_EXTENSION).build();
+ .withFileExtension(HoodieLogFile.DELTA_EXTENSION);
+
+ String logVersionKey = logVersionLookupKey(partitionPath, fileId,
rollbackRequest.getLatestBaseInstant());
Review Comment:
As V8+ only creates log files and is not appending log blocks to files,
removed the dead code from RollbackHelper, while keeping the changes in
RollbackHelperV1 for backward compatibility. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
