the-other-tim-brown commented on code in PR #18347:
URL: https://github.com/apache/hudi/pull/18347#discussion_r2990681783
##########
hudi-spark-datasource/hudi-spark3.3.x/src/main/scala/org/apache/spark/sql/parser/HoodieSpark3_3ExtendedSqlAstBuilder.scala:
##########
@@ -2713,11 +2727,18 @@ class HoodieSpark3_3ExtendedSqlAstBuilder(conf:
SQLConf, delegate: ParserInterfa
*/
override def visitComplexColType(ctx: ComplexColTypeContext): StructField =
withOrigin(ctx) {
import ctx._
- val structField = StructField(
+ val builder = new MetadataBuilder
+ // Add comment to metadata
+ Option(commentSpec()).map(visitCommentSpec).foreach {
+ builder.putString("comment", _)
+ }
+ addMetadataForType(ctx.dataType(), builder)
+
+ StructField(
name = identifier.getText,
dataType = typedVisit(dataType()),
- nullable = NULL == null)
-
Option(commentSpec).map(visitCommentSpec).map(structField.withComment).getOrElse(structField)
Review Comment:
it is slightly but you are just creating another metadata object and then
another struct field if there is a comment on the field
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
