the-other-tim-brown commented on code in PR #18347:
URL: https://github.com/apache/hudi/pull/18347#discussion_r2990694231
##########
hudi-spark-datasource/hudi-spark3.4.x/src/main/scala/org/apache/spark/sql/parser/HoodieSpark3_4ExtendedSqlAstBuilder.scala:
##########
@@ -2689,13 +2692,24 @@ class HoodieSpark3_4ExtendedSqlAstBuilder(conf:
SQLConf, delegate: ParserInterfa
builder.putString("comment", _)
}
+ val dataType = typedVisit[DataType](ctx.dataType)
+
+ addMetadataForType(ctx.dataType(), builder)
+
StructField(
name = colName.getText,
- dataType = typedVisit[DataType](ctx.dataType),
+ dataType = dataType,
nullable = NULL == null,
metadata = builder.build())
}
+ private def addMetadataForType(dataType:
HoodieSqlBaseParser.DataTypeContext, builder: MetadataBuilder): Unit = {
+ val typeText = dataType.getText
+ if (typeText.equalsIgnoreCase(HoodieSchemaType.BLOB.name())) {
+ builder.putString(HoodieSchema.TYPE_METADATA_FIELD,
HoodieSchemaType.BLOB.name())
+ }
+ }
+
Review Comment:
I don't know. These classes are made up of almost entirely duplicated code.
Thousands of lines of it. So I am guessing the answer is no, otherwise they
would not be structured like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
