satishkotha opened a new pull request #2502:
URL: https://github.com/apache/hudi/pull/2502


   ## What is the purpose of the pull request
   
   Fix 2 issues found during large scale testing of clustering
   
   ## Brief change log
   
   * writeStatusRDD.isEmpty() call is taking 15-25% empty and limiting 
parallelism for clustering.
   * bug using 'int' during plan generation instead of long is limiting 
clustering max group size.
   
   ## Verify this pull request
   
   This pull request is already covered by existing tests, such as.
   1)TestHoodieClientOnCopyOnWriteStorage#testClusteringWithSortColumns, 
testSimpleClustering
   2) TestHoodieMergeOnReadTable#testSimpleClusteringWithUpdates, 
testSimpleClusteringNoUpdates
   
   I repeated this test on large scale dataset and verified this improves 
runtime of clustering operation by 20%
   
   We can add more specific tests for measuring performance and validating 
clustering plan. I plan to take it up as separate item. This probably requires 
updating 0.7 release because performance improvement is substantial
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to