satishkotha commented on a change in pull request #2502:
URL: https://github.com/apache/hudi/pull/2502#discussion_r565810597
##########
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/clustering/plan/strategy/SparkRecentDaysClusteringPlanStrategy.java
##########
@@ -71,20 +71,26 @@ public
SparkRecentDaysClusteringPlanStrategy(HoodieSparkMergeOnReadTable<T> tabl
protected Stream<HoodieClusteringGroup>
buildClusteringGroupsForPartition(String partitionPath, List<FileSlice>
fileSlices) {
List<Pair<List<FileSlice>, Integer>> fileSliceGroups = new ArrayList<>();
List<FileSlice> currentGroup = new ArrayList<>();
- int totalSizeSoFar = 0;
+ long totalSizeSoFar = 0;
for (FileSlice currentSlice : fileSlices) {
// assume each filegroup size is ~= parquet.max.file.size
totalSizeSoFar += currentSlice.getBaseFile().isPresent() ?
currentSlice.getBaseFile().get().getFileSize() :
getWriteConfig().getParquetMaxFileSize();
// check if max size is reached and create new group, if needed.
if (totalSizeSoFar >= getWriteConfig().getClusteringMaxBytesInGroup() &&
!currentGroup.isEmpty()) {
- fileSliceGroups.add(Pair.of(currentGroup,
getNumberOfOutputFileGroups(totalSizeSoFar,
getWriteConfig().getClusteringTargetFileMaxBytes())));
+ int numOutputGroups = getNumberOfOutputFileGroups(totalSizeSoFar,
getWriteConfig().getClusteringTargetFileMaxBytes());
Review comment:
this is just for logging improvement
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
