nsivabalan commented on a change in pull request #2449:
URL: https://github.com/apache/hudi/pull/2449#discussion_r567256239
##########
File path:
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java
##########
@@ -63,6 +63,10 @@
public HiveSyncTool(HiveSyncConfig cfg, HiveConf configuration, FileSystem
fs) {
super(configuration.getAllProperties(), fs);
+ //Set Hive meta store URI which enables synchronize to remote hive
+ if (cfg.hiveMetaStoreUri != null) {
Review comment:
I see that we set a default value for this new config in
DataSourceUtils( thrift://localhost:9083). So, for someone who does not set
this, I assume it should be no-op even though we set to some default value. I
don't have much knowledge on hive megastore and sync. So, might be a naive
question.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]