danny0405 commented on code in PR #18702:
URL: https://github.com/apache/hudi/pull/18702#discussion_r3212447168
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/storage/row/parquet/ParquetSchemaConverter.java:
##########
@@ -190,6 +201,38 @@ public static MessageType
convertToParquetMessageType(String name, RowType rowTy
return new MessageType(name, types);
}
+ /**
+ * Checks whether the group carries the Parquet {@code VARIANT} logical type
annotation.
+ * Uses class-name matching so this compiles against parquet-java versions
that predate the
+ * {@code VariantLogicalTypeAnnotation} class (< 1.15.2).
+ */
+ private static boolean hasVariantAnnotation(LogicalTypeAnnotation
logicalType) {
Review Comment:
yeah, add a TODO to add variant on writer side first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
