n3nash commented on a change in pull request #2359:
URL: https://github.com/apache/hudi/pull/2359#discussion_r578071271
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##########
@@ -236,17 +226,16 @@ protected void syncTableMetadata() {
* Main API to run bootstrap to hudi.
*/
public void bootstrap(Option<Map<String, String>> extraMetadata) {
- if (rollbackPending) {
- rollBackInflightBootstrap();
- }
+ // TODO : MULTIWRITER -> check if failed bootstrap files can be cleaned
later
HoodieTable<T, I, K, O> table =
getTableAndInitCtx(WriteOperationType.UPSERT,
HoodieTimeline.METADATA_BOOTSTRAP_INSTANT_TS);
+ rollbackFailedBootstrap();
table.bootstrap(context, extraMetadata);
}
/**
- * Main API to rollback pending bootstrap.
+ * Main API to rollback failed bootstrap.
*/
- protected void rollBackInflightBootstrap() {
+ public void rollbackFailedBootstrap() {
Review comment:
We are deprecating the use pf `rollback` API since that api currently
supports rolling back failed and valid commits. Rollback of valid commits is
only supported through `restore`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
