n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r578080260
########## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/heartbeat/HeartbeatUtils.java ########## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.client.heartbeat; + +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.Path; +import org.apache.hudi.common.table.HoodieTableMetaClient; +import org.apache.hudi.common.table.timeline.HoodieInstant; +import org.apache.hudi.common.util.ValidationUtils; +import org.apache.hudi.config.HoodieWriteConfig; +import org.apache.hudi.exception.HoodieException; +import org.apache.hudi.table.HoodieTable; +import org.apache.log4j.LogManager; +import org.apache.log4j.Logger; + +import java.io.File; +import java.io.IOException; +import java.util.List; +import java.util.Set; +import java.util.stream.Collectors; + +/** + * Helper class to delete heartbeat for completed or failed instants with expired heartbeats. + */ +public class HeartbeatUtils { + + private static final Logger LOG = LogManager.getLogger(HeartbeatUtils.class); + + /** + * Deletes the heartbeat file for the specified instant. + * @param fs + * @param basePath + * @param instantTime + * @return + */ + public static boolean deleteHeartbeatFile(FileSystem fs, String basePath, String instantTime) { + boolean deleted = false; + try { + String heartbeatFolderPath = HoodieTableMetaClient.getHeartbeatFolderPath(basePath); + deleted = fs.delete(new Path(heartbeatFolderPath + File.separator + instantTime), false); + if (!deleted) { + LOG.error("Failed to delete heartbeat for instant " + instantTime); + } + } catch (IOException io) { + LOG.error("Unable to delete heartbeat for instant " + instantTime, io); Review comment: No, not being able to delete heartbeat is benign, should not be a drastic failure for job. ########## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/heartbeat/HeartbeatUtils.java ########## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.client.heartbeat; + +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.Path; +import org.apache.hudi.common.table.HoodieTableMetaClient; +import org.apache.hudi.common.table.timeline.HoodieInstant; +import org.apache.hudi.common.util.ValidationUtils; +import org.apache.hudi.config.HoodieWriteConfig; +import org.apache.hudi.exception.HoodieException; +import org.apache.hudi.table.HoodieTable; +import org.apache.log4j.LogManager; +import org.apache.log4j.Logger; + +import java.io.File; +import java.io.IOException; +import java.util.List; +import java.util.Set; +import java.util.stream.Collectors; + +/** + * Helper class to delete heartbeat for completed or failed instants with expired heartbeats. + */ +public class HeartbeatUtils { + + private static final Logger LOG = LogManager.getLogger(HeartbeatUtils.class); + + /** + * Deletes the heartbeat file for the specified instant. + * @param fs + * @param basePath + * @param instantTime + * @return + */ + public static boolean deleteHeartbeatFile(FileSystem fs, String basePath, String instantTime) { + boolean deleted = false; + try { + String heartbeatFolderPath = HoodieTableMetaClient.getHeartbeatFolderPath(basePath); + deleted = fs.delete(new Path(heartbeatFolderPath + File.separator + instantTime), false); + if (!deleted) { + LOG.error("Failed to delete heartbeat for instant " + instantTime); Review comment: No, sometimes the underlying DFS may not delete the file due to an exception. Unfortunately, the `delete` API does not return an exception. We are logging the error here as opposed to throwing an exception since not being able to delete a heartbeat is benign and repeatable. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
