nsivabalan commented on pull request #2106: URL: https://github.com/apache/hudi/pull/2106#issuecomment-789807546
@Karl-WangSK @vinothchandar : since its been open for some time, wanted to see how we can get it to closure. let me summarize the state of the PR. Requirement: We wish to support new preCombine logic to preCombine two records within same incoming batch (if config is enabled). Logic: any field w/ null value in record w/ latest ordering value, will pick value from the other row. Few clarifying questions: - Is this just for PreCombine or even for combineAndGetUpdateValue as well? - If there are more than 2 records, we apply the same logic right? So, initial proposal was to change the signature of preCombine to take in schema. but feedback was given to try out serializable version so that we don't need to change the api and incur perf impact. @Karl-WangSK : feel free to clarify my questions and give us the latest update on this PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
