voonhous commented on code in PR #18837:
URL: https://github.com/apache/hudi/pull/18837#discussion_r3340340861
##########
hudi-trino-plugin/src/main/java/io/trino/plugin/hudi/stats/TableMetadataReader.java:
##########
@@ -55,60 +48,29 @@ public class TableMetadataReader
* @return a map from column name to their corresponding {@link
HoodieColumnRangeMetadata}
* @throws HoodieMetadataException if an error occurs while fetching the
column statistics
*/
- Map<String, HoodieColumnRangeMetadata> getColumnStats(List<Pair<String,
String>> partitionNameFileNameList, List<String> columnNames)
+ public Map<String, HoodieColumnRangeMetadata>
getColumnsRange(List<Pair<String, String>> partitionNameFileNameList,
List<String> columnNames)
Review Comment:
Addressed in eec0cc6. `getColumnsRange` is now package-private. Its only
caller (`TableStatisticsReader`) is in the same `io.trino.plugin.hudi.stats`
package and is also the only place that constructs `TableMetadataReader` (whose
constructor is already package-private), so `public` was unnecessary. Narrowing
it removes the surface overlap with the inherited public
`HoodieBackedTableMetadata.getColumnStats`, so external/future callers can no
longer pick the wrong one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
