voonhous commented on code in PR #18837:
URL: https://github.com/apache/hudi/pull/18837#discussion_r3340419812
##########
hudi-trino-plugin/src/main/java/io/trino/plugin/hudi/HudiTableHandle.java:
##########
@@ -66,12 +67,13 @@ public HudiTableHandle(
@JsonProperty("basePath") String basePath,
@JsonProperty("tableType") HoodieTableType tableType,
@JsonProperty("partitionColumns") List<HiveColumnHandle>
partitionColumns,
+ @JsonProperty("orderingColumns") List<HiveColumnHandle>
orderingColumns,
@JsonProperty("partitionPredicates") TupleDomain<HiveColumnHandle>
partitionPredicates,
@JsonProperty("regularPredicates") TupleDomain<HiveColumnHandle>
regularPredicates,
@JsonProperty("tableSchemaStr") String tableSchemaStr,
@JsonProperty("latestCommitTime") String latestCommitTime)
{
- this(Optional.empty(), Optional.empty(), schemaName, tableName,
basePath, tableType, partitionColumns, ImmutableSet.of(),
+ this(Optional.empty(), Optional.empty(), schemaName, tableName,
basePath, tableType, partitionColumns, Lazy.lazily(() -> orderingColumns),
ImmutableSet.of(),
partitionPredicates, regularPredicates,
buildTableSchema(tableSchemaStr), () -> latestCommitTime);
Review Comment:
Addressed in 86d97d0. The `@JsonCreator` path receives an
already-materialized `orderingColumns`, so it now uses
`Lazy.eagerly(orderingColumns)` instead of `Lazy.lazily(() ->
orderingColumns)`. The field stays `Lazy<List<HiveColumnHandle>>` because the
planning-path constructor genuinely supplies a deferred value (ordering columns
derived from a metadata load), so it cannot become a plain `List`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
