voonhous commented on code in PR #18837:
URL: https://github.com/apache/hudi/pull/18837#discussion_r3340457446
##########
docker/hoodie/hadoop/pom.xml:
##########
@@ -39,9 +39,6 @@
<module>sparkworker</module>
<module>sparkadhoc</module>
<module>prestobase</module>
- <module>trinobase</module>
- <module>trinocoordinator</module>
- <module>trinoworker</module>
</modules>
Review Comment:
All four items are resolved on the current branch:
1. The `docker/hoodie/hadoop/trino{base,coordinator,worker}/` sources
(Dockerfiles, scripts, etc, module poms) are removed - `git ls-files` shows
nothing tracked under them; only untracked, git-ignored `target/` build
artifacts remain locally.
2.
`docker/compose/docker-compose_hadoop284_hive2310_spark353_{amd64,arm64}.yml`
no longer declare `trino-coordinator-1` / `trino-worker-1`.
3. `docker/README.md` no longer documents trinobase build steps.
4. `scripts/release/validate_staged_bundles.sh` no longer lists
`hudi-trino-bundle`.
Repo-wide there are no remaining `hudi-trino-bundle` references, and the
parent `docker/hoodie/hadoop/pom.xml` no longer lists the trino modules.
One related remnant not in this list: `hudi-integ-test/.../ITTestBase.java`
still defines `TRINO_COORDINATOR` / `TRINO_COORDINATOR_URL` (pointing at
`trino-coordinator-1`), used only by the `testTrinoAfter*` methods in
`ITTestHoodieDemo` - which are all commented out behind `// TODO(HUDI-8269,
HUDI-8270): fix integration tests with Presto and Trino`. Nothing breaks at
runtime since that demo flow is already disabled; those constants will be
refreshed/removed when the integ Trino demo is rewired under those JIRAs.
##########
pom.xml:
##########
@@ -59,7 +59,6 @@
<module>packaging/hudi-utilities-bundle</module>
<module>packaging/hudi-utilities-slim-bundle</module>
<module>packaging/hudi-timeline-server-bundle</module>
- <module>packaging/hudi-trino-bundle</module>
<module>hudi-examples</module>
Review Comment:
Both are resolved: `docker/hoodie/hadoop/trinobase` (module pom +
Dockerfile) is removed and `scripts/release/validate_staged_bundles.sh` no
longer lists `hudi-trino-bundle`. Repo-wide there are no remaining
`hudi-trino-bundle` references and the parent `docker/hoodie/hadoop/pom.xml` no
longer lists the trino modules. See the punch-list reply on the later round
(discussion_r3317485924) for the full item-by-item status.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
