danny0405 commented on code in PR #18911:
URL: https://github.com/apache/hudi/pull/18911#discussion_r3360035524
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieFileFormat.java:
##########
@@ -56,8 +56,8 @@ public enum HoodieFileFormat {
LANCE(".lance");
public static final String LANCE_SPARK_ONLY_ERROR_MSG =
Review Comment:
Done. Renamed the constant to `LANCE_UNSUPPORTED_ERROR_MSG` and updated all
call sites.
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/format/mor/MergeOnReadInputFormat.java:
##########
@@ -270,6 +276,22 @@ private void mayShiftInputSplit(MergeOnReadInputSplit
split) throws IOException
}
protected ClosableIterator<RowData> getBaseFileIterator(String path) throws
IOException {
+ if (path.endsWith(HoodieFileFormat.LANCE.getFileExtension())) {
Review Comment:
Added CDC coverage by parameterizing
`TestInputFormat.testReadChangelogIncrementallyForMorWithCompaction` over
`PARQUET` and `LANCE`. The Lance case exercises MOR compaction with CDC enabled
so the base-file CDC inference path reads Lance base files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
