danny0405 commented on code in PR #18911:
URL: https://github.com/apache/hudi/pull/18911#discussion_r3360036205
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/reader/function/HoodieCdcSplitReaderFunction.java:
##########
@@ -278,8 +284,24 @@ private ClosableIterator<HoodieRecord<RowData>>
getFileSliceHoodieRecordIterator
}
}
- /** Reads a parquet CDC base file returning required-schema records. */
+ /** Reads a CDC base file returning required-schema records. */
private ClosableIterator<RowData> getBaseFileIterator(String path) throws
IOException {
+ if (path.endsWith(HoodieFileFormat.LANCE.getFileExtension())) {
Review Comment:
Done. Extracted the shared Lance RowData reader setup into
`FormatUtils.getLanceRecordIterator` and reused it from
`MergeOnReadInputFormat`, `HoodieCdcSplitReaderFunction`, and the existing COW
Lance path so schema construction and close/error handling stay in one place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
