satishkotha commented on a change in pull request #2622:
URL: https://github.com/apache/hudi/pull/2622#discussion_r590748375
##########
File path:
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/io/TestHoodieTimelineArchiveLog.java
##########
@@ -495,11 +496,16 @@ private void createReplaceMetadata(String instantTime)
throws Exception {
String fileId2 = "file-" + instantTime + "-2";
// create replace instant to mark fileId1 as deleted
+ HoodieRequestedReplaceMetadata requestedReplaceMetadata =
HoodieRequestedReplaceMetadata.newBuilder()
+ .setOperationType(WriteOperationType.INSERT_OVERWRITE.toString())
+ .setVersion(1)
Review comment:
@n3nash This is not related to timeline layout version. This is tracking
version of HoodieRequestedReplaceMetadata (in case we add new fields to replace
metadata avro structure, we can increase version).
In the test, we were actually already configured to use default timeline
layout version 1. But test was only creating commit file and was not creating
requested files. I modified to add requested files as it happens with timeline
layout version 1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
