voonhous commented on code in PR #13147:
URL: https://github.com/apache/hudi/pull/13147#discussion_r3401710892


##########
hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/RequestHandler.java:
##########
@@ -240,6 +252,30 @@ private void registerTimelineAPI() {
       TimelineDTO dto = instantHandler.getTimeline(getBasePathParam(ctx));
       writeValueAsString(ctx, dto);
     }, false));
+
+    app.get(RemoteHoodieTableFileSystemView.TIMELINE_V2_URL, new 
ViewHandler(ctx -> {

Review Comment:
   Agreed, and this matches the RFC (v2 registration gated behind 
`--enable-ui`). Moved the four v2 routes (timeline, instant details, table 
config, schema history) into a new `registerTimelineV2API()` that is only 
called when `enableUi` is set, alongside the static files and `UiHandler`. The 
v1 endpoints (`LAST_INSTANT`, `TIMELINE`) stay unconditional. These v2 URLs are 
only consumed by the UI frontend, so nothing else is affected.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to