voonhous commented on code in PR #13147:
URL: https://github.com/apache/hudi/pull/13147#discussion_r3401845144
##########
hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/TimelineService.java:
##########
@@ -250,7 +266,7 @@ public void run() throws IOException {
public static FileSystemViewManager buildFileSystemViewManager(Config
config, StorageConfiguration<?> conf) {
HoodieLocalEngineContext localEngineContext = new
HoodieLocalEngineContext(conf);
// Just use defaults for now
- HoodieMetadataConfig metadataConfig =
HoodieMetadataConfig.newBuilder().build();
+ HoodieMetadataConfig metadataConfig =
HoodieMetadataConfig.newBuilder().enable(false).build();
Review Comment:
Intentional. The standalone timeline server (which backs the Timeline UI)
serves read-only timeline data for arbitrary table basepaths, so it should not
require each table to have a metadata table present or bootstrapped; with MDT
disabled it falls back to direct storage listing. Replaced the stale "Just use
defaults for now" comment with this rationale.
Scope is limited to the standalone `buildFileSystemViewManager` path (only
called from `TimelineService` startup). The embedded server is unaffected: it
builds its own view manager from the writer's metadata config via
`EmbeddedTimelineService.createViewManager()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
