nsivabalan commented on code in PR #18585:
URL: https://github.com/apache/hudi/pull/18585#discussion_r3407154228
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/validator/SparkPreCommitValidator.java:
##########
@@ -82,6 +82,11 @@ public void validate(String instantTime,
HoodieWriteMetadata<O> writeResult, Dat
HoodieTimer timer = HoodieTimer.start();
try {
validateRecordsBeforeAndAfter(before, after,
getPartitionsModified(writeResult));
+ } catch (HoodieValidationException e) {
+ throw e;
+ } catch (Exception e) {
Review Comment:
👍 Force-push to `98d70681` addresses this — `catch (RuntimeException e) {
throw e; }` now propagates NPE/CCE/etc. crash-loud with the original stack, and
checked exceptions get promoted to `RuntimeException` instead of being
downgraded to `HoodieValidationException`. `runValidator()` continues to catch
only `HoodieValidationException` for legit validation failures. Exactly the
right shape. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
