hudi-agent commented on code in PR #18877:
URL: https://github.com/apache/hudi/pull/18877#discussion_r3425481338
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/storage/row/parquet/ParquetRowDataWriter.java:
##########
@@ -141,21 +151,29 @@ private FieldWriter createWriter(LogicalType t) {
return new Timestamp96Writer(tsLtzPrecision);
}
case ARRAY:
Review Comment:
🤖 nit: `nonNullSchema` can be null — the ARRAY branch passes `nonNullSchema
== null ? null : nonNullSchema.getElementType()` to the recursive call. The
name implies a non-null guarantee that isn't there, which could mislead a
future reader. `resolvedSchema` (the term used for the same `getNonNullType()`
result in `ParquetSchemaConverter`) would be both more honest and consistent.
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
