danny0405 commented on code in PR #18877:
URL: https://github.com/apache/hudi/pull/18877#discussion_r3433261035
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/storage/row/parquet/ParquetRowDataWriter.java:
##########
@@ -97,7 +105,9 @@ public void write(final RowData record) {
recordConsumer.endMessage();
}
- private FieldWriter createWriter(LogicalType t) {
+ private FieldWriter createWriter(LogicalType t, HoodieSchema fieldSchema) {
+ // strip the nullable wrapper so the element/key/value/record sub-schemas
can be resolved directly
+ HoodieSchema nonNullSchema = fieldSchema.getNonNullType();
Review Comment:
this is so annoying, can we pass around the non-null schema in the first
place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
