yihua commented on code in PR #19029:
URL: https://github.com/apache/hudi/pull/19029#discussion_r3425959626
##########
hudi-common/src/main/java/org/apache/hudi/internal/schema/action/TableChanges.java:
##########
@@ -47,13 +47,19 @@ public static class ColumnUpdateChange extends
TableChange.BaseColumnChange {
@Getter
private final Map<Integer, Types.Field> updates = new HashMap<>();
+ private final boolean allowTimestampPrecisionEvolution;
private ColumnUpdateChange(InternalSchema schema) {
- super(schema, false);
+ this(schema, false, false);
}
private ColumnUpdateChange(InternalSchema schema, boolean caseSensitive) {
+ this(schema, caseSensitive, false);
+ }
+
+ private ColumnUpdateChange(InternalSchema schema, boolean caseSensitive,
boolean allowTimestampPrecisionEvolution) {
Review Comment:
Fixed.
##########
hudi-common/src/main/java/org/apache/hudi/internal/schema/utils/SchemaChangeUtils.java:
##########
@@ -52,29 +52,39 @@ public class SchemaChangeUtils {
* @param dst new column type.
* @return whether to allow the column type to be updated.
*/
- public static boolean isTypeUpdateAllow(Type src, Type dst) {
+ /**
+ * Variant that allows opting in to timestamp-millis <-> timestamp-micros
(and the local-timestamp
+ * variants) precision evolution, which is rejected by default.
+ */
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
