wombatu-kun commented on code in PR #19029:
URL: https://github.com/apache/hudi/pull/19029#discussion_r3427189945
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieCommonConfig.java:
##########
@@ -83,6 +83,15 @@ public class HoodieCommonConfig extends HoodieConfig {
+ " operation will fail schema compatibility check. Set this option
to true will make the missing "
+ " column be filled with null values to successfully complete the
write operation.");
+ public static final ConfigProperty<Boolean>
ALLOW_TIMESTAMP_PRECISION_EVOLUTION = ConfigProperty
+ .key("hoodie.write.schema.allow.timestamp.precision.evolution")
+ .defaultValue(false)
+ .markAdvanced()
+ .sinceVersion("1.3.0")
+ .withDocumentation("Controls whether schema evolution may change a
column between timestamp-millis and "
Review Comment:
This omits the third behavior the flag gates: attaching a logical type to a
bare `long` (`long -> local-timestamp-millis/micros`), the logical-type-loss
repair the PR description calls a primary motivation. A user whose 0.x table
stored the column as bare long would not learn from "precision-only evolution
between these logical types" that this flag applies. Suggest documenting the
`long -> local-timestamp` attach case explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
