nsivabalan commented on PR #18805:
URL: https://github.com/apache/hudi/pull/18805#issuecomment-4765378500
Reworked per @wombatu-kun's review to restore HUDI-4167's narrow gate while
still tolerating missing files in the include= recursion case:
- Public `addPropsFromFile(StoragePath)` now throws `HoodieIOException` on
missing file (restores fail-fast for `UtilHelpers.readConfig` /
`StreamerUtil.readConfig` / `HDFSParquetImporterUtils.readConfig` — Delta
Streamer / Flink / Spark CLI `--props`).
- New internal `addPropsFromFile(StoragePath, boolean tolerateMissing)`
overload, used by:
- `loadGlobalProps` for `DEFAULT_PATH` (`hudi-defaults.conf`)
- `loadGlobalProps` for the `HUDI_CONF_DIR`-derived path
- `addPropsFromStream`'s `include=` recursion
- Log level on the DEFAULT_PATH branch kept at `debug` per HUDI-13986 (was
being promoted to `warn`).
Added `testExplicitMissingPropertiesFileThrows` covering both the
constructor and the public method. Existing `testIncludeNonExistentFile` /
`testIncludeNonExistentRelativeFile` /
`testMixedExistentAndNonExistentIncludes` /
`testClassInitializationNeverThrows` continue to pass via the tolerant path.
Ready for review. @wombatu-kun @danny0405 PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
