nsivabalan commented on code in PR #18805:
URL: https://github.com/apache/hudi/pull/18805#discussion_r3478944927
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/common/config/DFSPropertiesConfiguration.java:
##########
@@ -156,8 +156,8 @@ public void addPropsFromFile(StoragePath filePath) {
);
try {
- if (filePath.equals(DEFAULT_PATH) && !storage.exists(filePath)) {
- log.debug("Properties file {} not found. Ignoring to load props file",
filePath);
+ if (!storage.exists(filePath)) {
Review Comment:
Latest commit (3d1bbb1d8146) extends the prior scoping: the single-arg
public `addPropsFromFile(StoragePath)` now tolerates a missing file iff the
path equals `DEFAULT_PATH`, so the global-defaults idiom keeps working when
callers hit `UtilHelpers.readConfig` / `StreamerUtil.readConfig` with
`cfg.propsFilePath = DFSPropertiesConfiguration.DEFAULT_PATH.toString()` (the
no-op marker pattern several HoodieStreamer E2E tests use). Every other
explicit path still fails fast — `testExplicitMissingPropertiesFileThrows`
covers that. Resolving this thread; the env-conf-path case from your follow-up
is still tolerant via `loadGlobalProps`'s explicit two-arg call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
